Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle skip_resolving (need to fix in inspect mod too) #513

Closed
github-actions bot opened this issue Nov 4, 2024 · 1 comment · Fixed by #527
Closed

handle skip_resolving (need to fix in inspect mod too) #513

github-actions bot opened this issue Nov 4, 2024 · 1 comment · Fixed by #527
Assignees
@Jon-Becker
Labels
T-todo Type: todo todo

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

New Codebase TODO

handle skip_resolving (need to fix in inspect mod too)

Location

heimdall-rs/crates/decompile/src/utils/heuristics/extcall.rs

Line 138 in 153f067

// TODO: handle skip_resolving (need to fix in inspect mod too) 

    Ok(())
}

// TODO: handle skip_resolving (need to fix in inspect mod too)
// TODO: handle case where decoding fails
@github-actions github-actions bot added T-todo Type: todo todo labels Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Dec 7, 2024

Closed in bda45bc

@github-actions github-actions bot closed this as completed Dec 7, 2024
@Jon-Becker Jon-Becker linked a pull request Dec 7, 2024 that will close this issue
fix(decode): respect skip_resolving in inspect and decompile mods #527
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jon-Becker Jon-Becker

Labels
T-todo Type: todo todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(decode): respect skip_resolving in inspect and decompile mods Jon-Becker/heimdall-rs
1 participant
@Jon-Becker