Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(decode): respect skip_resolving in inspect and decompile mods #527

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Jon-Becker
Copy link
Owner

Motivation

Solution

@Jon-Becker Jon-Becker linked an issue Dec 7, 2024 that may be closed by this pull request
@Jon-Becker Jon-Becker merged commit 2c6f2d6 into main Dec 7, 2024
8 checks passed
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Benchmark for f49d39c

Click to view benchmark
Test Base PR %
heimdall_cfg/complex 13.5±0.06ms 13.1±1.41ms -2.96%
heimdall_cfg/simple 2.1±0.01ms 1917.8±16.62µs -8.68%
heimdall_decoder/seaport 33.5±0.83µs 34.2±0.77µs +2.09%
heimdall_decoder/transfer 3.7±0.19µs 3.5±0.20µs -5.41%
heimdall_decoder/uniswap 10.7±0.31µs 10.8±0.51µs +0.93%
heimdall_decompiler/abi_complex 55.6±0.39ms 50.8±0.20ms -8.63%
heimdall_decompiler/abi_simple 2.0±0.01ms 2.1±0.00ms +5.00%
heimdall_decompiler/sol_complex 64.6±0.58ms 60.8±0.27ms -5.88%
heimdall_decompiler/sol_simple 2.4±0.01ms 2.5±0.01ms +4.17%
heimdall_decompiler/yul_complex 57.1±0.50ms 53.2±0.32ms -6.83%
heimdall_decompiler/yul_simple 2.1±0.01ms 2.1±0.01ms 0.00%
heimdall_disassembler/complex 778.5±16.15µs 782.8±17.01µs +0.55%
heimdall_disassembler/simple 38.6±0.79µs 39.1±1.05µs +1.30%
heimdall_vm/erc20_transfer 299.6±16.64µs 300.6±35.43µs +0.33%
heimdall_vm/fib 677.6±11.71µs 712.8±6.72µs +5.19%
heimdall_vm/ten_thousand_hashes 577.4±5.61ms 581.9±6.66ms +0.78%

@Jon-Becker Jon-Becker deleted the jon-becker/fix-skip-resolving branch December 27, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle skip_resolving (need to fix in inspect mod too)
1 participant