Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(decompile): add support for LOG0 anonymous events #255

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

Jon-Becker
Copy link
Owner

Motivation

Solution

@Jon-Becker Jon-Becker linked an issue Dec 28, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [clippy] reported by reviewdog 🐶

warning: you seem to use `.enumerate()` and immediately discard the index
   --> core/src/decompile/analyzers/yul.rs:420:23
    |
420 |     for (_, child) in vm_trace.children.iter().enumerate() {
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
    = note: `#[warn(clippy::unused_enumerate_index)]` on by default
help: remove the `.enumerate()` call
    |
420 |     for child in vm_trace.children.iter() {
    |         ~~~~~    ~~~~~~~~~~~~~~~~~~~~~~~~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [clippy] reported by reviewdog 🐶

warning: you seem to use `.enumerate()` and immediately discard the index
   --> core/src/snapshot/analyze.rs:534:23
    |
534 |     for (_, child) in vm_trace.children.iter().enumerate() {
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
help: remove the `.enumerate()` call
    |
534 |     for child in vm_trace.children.iter() {
    |         ~~~~~    ~~~~~~~~~~~~~~~~~~~~~~~~

@Jon-Becker Jon-Becker merged commit 7e0e071 into main Dec 28, 2023
7 checks passed
@Jon-Becker Jon-Becker deleted the jon-becker/support-log0-anon-events branch January 1, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decompile: panicked in solidity.rs, unwrap on a None value
1 participant