fix(decode): various decode fixes introduced in f168506 #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-Becker
changed the title
Jon-Becker
changed the title
Jon-Becker
added a commit
that referenced
this pull request
Jan 30, 2024
* chore(common): hardening common, `.unwrap()` purge * chore(common): hardening VM ops, `.unwrap()` purge * chore(common): remove flaky VM usize conversions, use `?` * chore(common): hardening common, `.unwrap()` purge * chore: use unwrap_or(false) rather than error propogation for regex matching (#284) * chore: use `unwrap_or(false)` rather than error propogation for regex matching * chore(clippy): make clippy happy * chore: merge `main` into `jon-becker/common-hardening` * chore(core): purge all instances of `.unwrap()`, proper error handling(ish) (#292) * [DRAFT] chore: convert all instances of bytecode, calldata to Vec<u8> (#309) * chore: convert all instances of bytecode, calldata to `Vec<u8>` * chore(decode): retype all instances of calldata as `Vec<u8>` * fix(cache): doctests cannot access private mod `util` * fix(decode): various decode fixes introduced in f168506 (#311) * fix(decompile): solidity postprocessing things (#313) * fix(tests): update test cases for postprocessing cleanup (#314)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution