Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): alloy 0.3.3 #498

Merged
merged 8 commits into from
Sep 17, 2024
Merged

chore(deps): alloy 0.3.3 #498

merged 8 commits into from
Sep 17, 2024

Conversation

fala13
Copy link
Contributor

@fala13 fala13 commented Sep 16, 2024

Motivation

Current @bluealloy/revm uses 0.3.

Solution

Trivial changes just to get it to compile.

@fala13 fala13 requested a review from Jon-Becker as a code owner September 16, 2024 21:51
Copy link
Owner

@Jon-Becker Jon-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you for doing this ❤️

@fala13
Copy link
Contributor Author

fala13 commented Sep 17, 2024

Even though I've set the rust-version = "1.79" the bench job complains that 1.78 is used. I don't see other mentions of 1.78 in the code.

@Jon-Becker
Copy link
Owner

Jon-Becker commented Sep 17, 2024

tests likely wont pass because of the rpc secrets, im going to fix 1.79 clippy lints and then ill be able to merge this if tests pass locally!

(i fixed the CI with a rust-toolchain.toml file)

@Jon-Becker
Copy link
Owner

tests passing locally, merging after benches!

@Jon-Becker Jon-Becker merged commit 5517ba7 into Jon-Becker:main Sep 17, 2024
5 of 7 checks passed
@fala13 fala13 deleted the alloy-update branch September 18, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants