Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): JUMPI dest overflow check #534

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Jon-Becker
Copy link
Owner

Motivation

Solution

@Jon-Becker Jon-Becker linked an issue Dec 12, 2024 that may be closed by this pull request
2 tasks
@Jon-Becker Jon-Becker merged commit 7ee0f23 into main Dec 12, 2024
8 checks passed
Copy link
Contributor

Benchmark for 2774735

Click to view benchmark
Test Base PR %
heimdall_cfg/complex 14.6±1.51ms 15.0±1.08ms +2.74%
heimdall_cfg/simple 2.2±0.10ms 2.2±0.03ms 0.00%
heimdall_decoder/seaport 42.7±4.63µs 43.6±4.90µs +2.11%
heimdall_decoder/transfer 3.0±0.42µs 3.1±0.42µs +3.33%
heimdall_decoder/uniswap 12.5±1.78µs 12.3±1.21µs -1.60%
heimdall_decompiler/abi_complex 63.2±2.54ms 66.9±1.15ms +5.85%
heimdall_decompiler/abi_simple 2.3±0.10ms 2.4±0.10ms +4.35%
heimdall_decompiler/sol_complex 78.4±3.69ms 78.5±4.55ms +0.13%
heimdall_decompiler/sol_simple 2.9±0.06ms 2.8±0.03ms -3.45%
heimdall_decompiler/yul_complex 70.1±3.38ms 67.7±2.97ms -3.42%
heimdall_decompiler/yul_simple 2.6±0.14ms 2.5±0.10ms -3.85%
heimdall_disassembler/complex 976.2±95.45µs 944.0±92.02µs -3.30%
heimdall_disassembler/simple 46.4±5.45µs 48.3±4.53µs +4.09%
heimdall_vm/erc20_transfer 368.7±26.80µs 355.0±16.02µs -3.72%
heimdall_vm/fib 838.6±11.98µs 863.6±44.19µs +2.98%
heimdall_vm/ten_thousand_hashes 5.1±0.18s 5.2±0.14s +1.96%

@Jon-Becker Jon-Becker deleted the jon-becker/fix-jumpi-sanity-check branch December 27, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: crash on some small contract
1 participant