Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starry starry night #27

Open
ericvrp opened this issue Sep 5, 2022 · 2 comments
Open

Starry starry night #27

ericvrp opened this issue Sep 5, 2022 · 2 comments

Comments

@ericvrp
Copy link

ericvrp commented Sep 5, 2022

How can we go about adding a night full of (flickery?) stars that is completely visible at night and slightly visible during sunrise/sunset?

@JonahPlusPlus
Copy link
Owner

That's something I want to look into eventually, it's just not a priority right now.
My idea for how it could look:

  • Procedural Backend
    • Stars are just simple shapes (slightly blurred) that are arranged according to a seed value and colored based off provided color value
    • Pros
      • Simple
      • Performant
    • Cons
      • Not realistic
      • Very little artistic control
  • Artistic Backend
    • Star textures and their distribution range are provided via a Vec<StarInstance> and are arranged via a seed value
    • Pros
      • Allows for more realistic star textures and other objects (like planets, galaxies and different colored stars)
    • Cons
      • Less performant
      • More artistic work

If I go down this route (adding the artistic backend), I might want to consider adding support for custom sky textures to go along with it (would lack support for daylight cycles, but offers more artistic control).

@JonahPlusPlus JonahPlusPlus mentioned this issue Oct 1, 2022
7 tasks
@passivedragon
Copy link

How about a simpler type of solution?

Being able to "add" a skybox or the likes on top would allow for complete freedom, while also making all of these things possible (save for having the light interact with atmosphere, but there could be an optional post processing done to the texture to achieve the same effect. It would mean atmosphere simulation as such may be done twice, but I don't see that as something bad).

I'd love to have a simple way of rendering textures "on top", we'd get a way to add a costum texture for a sun/moon additionally for free that way.

From reading the linked issue, it seems this should be possible already, however I can't find any documentation on the procedual feature, or rather how to use the crate without it enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants