Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[need help] bevy 0.11 support #53

Closed
wants to merge 3 commits into from

Conversation

rlidwka
Copy link

@rlidwka rlidwka commented Jul 18, 2023

In this PR there are obvious changes. I made them, so you don't have to.

The problem: macros subcrate depends on syn 1, but bevy updated to syn 2.

Anyone here knows proc macros? Can you update macro folder, pretty please?

@rlidwka rlidwka marked this pull request as draft July 18, 2023 20:48
@robtfm
Copy link

robtfm commented Jul 20, 2023

i made a pr on your branch. it's actually fine for this crate to use syn 1.0, we just need to update the path of the AppTypeRegistry as per the migration guide. i also changed a few other things.

note that you'll need to patch bevy_spectator as well if that's not been updated already:

[patch.crates-io]
bevy_spectator = { git="https://github.com/GodGotzi/bevy_spectator" }

@VirxEC
Copy link
Contributor

VirxEC commented Jul 20, 2023

I tested this PR in my app, and it works perfectly!

@Shatur
Copy link
Collaborator

Shatur commented Jul 21, 2023

Superseded by #54.

@Shatur Shatur closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants