Fix Bitwuzla VARIABLE_NODE translation #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it an old bug or is it due to the new bitwuzla version? |
|
I think this also happens in the old version of Bitwuzla but I haven't checked. |
JonathanSalwan
merged commit adbc863
into
JonathanSalwan:dev-v1.0
28 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix an issue with the in the Triton to Bitwuzla translation for
VARIABLE_NODE. If a variable node appears more that once in an expression, different term for that node will be created. That means,bitwuzla_mk_constwill return differentBitwuzlaTerms for the same symbol. The fix checks whether the term was already created and returns it, otherwise creates a new one.