Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
For
avian_interpolation
, I want to have a clean separation between gameplay transforms and render transforms. Avian's best version of a gameplay scale is currentlyCollider::scale
. However, this is not ergonomically interpolatable due to two reasons:Collider::scale
is not initialized with the right scale, meaning that my observers that listen for its insertion will read wrong initial data, andGlobalTransform
, making it hard to change theTransform
according to theCollider::scale
without affecting it back in turnRelated to #444
Solution
Collider::scale
correctly in itson_add
hookSyncConfig
Changelog
Transform
toCollider::scale
syncing by using the newSyncConfig::transform_to_collider_scale
field.