fix(source): Dependency versions convention to latest

JoseLion · Sep 15, 2023 · 7d2bac1 · 7d2bac1
1 parent 231564a
commit 7d2bac1
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -114,9 +114,9 @@ strictNullCheck {
 | packageInfo.useEclipse()    | -                                                  | Shorcut function to set Eclipse's imports and annotations |
 | source                      | -                                                  | Container to configure the source of the annotations/imports |
 | source.dependencies         | []                                                 | List of short-style dependencies to be added to all _compileOnly_ classpaths |
-| source.addFindBugs(version) | version = `+` (resolves to latest)                 | Shortcut function to add `com.google.code.findbugs:jsr305` dependency |
-| source.addSpotBugs(version) | version = `+` (resolves to latest)                 | Shortcut function to add `com.github.spotbugs:spotbugs-annotations` dependency |
-| source.addEclipse(version)  | version = `+` (resolves to latest)                 | Shortcut function to add `org.eclipse.jdt:org.eclipse.jdt.annotation` dependency |
+| source.addFindBugs(version) | version = `3.0.2`                                  | Shortcut function to add `com.google.code.findbugs:jsr305` dependency |
+| source.addSpotBugs(version) | version = `4.7.3`                                  | Shortcut function to add `com.github.spotbugs:spotbugs-annotations` dependency |
+| source.addEclipse(version)  | version = `2.2.700`                                | Shortcut function to add `org.eclipse.jdt:org.eclipse.jdt.annotation` dependency |
 
 ### Overriding package-info.java
 

diff --git a/src/main/java/io/github/joselion/strictnullcheck/lib/StrictNullCheckExtension.java b/src/main/java/io/github/joselion/strictnullcheck/lib/StrictNullCheckExtension.java
@@ -131,23 +131,23 @@ public void addFindBugs(final String version) {
     }
 
     public void addFindBugs() {
-      this.addFindBugs("+");
+      this.addFindBugs("3.0.2");
     }
 
     public void addSpotBugs(final String version) {
       this.dependencies.add("com.github.spotbugs:spotbugs-annotations:".concat(version));
     }
 
     public void addSpotBugs() {
-      this.addSpotBugs("+");
+      this.addSpotBugs("4.7.3");
     }
 
     public void addEclipse(final String version) {
       this.dependencies.add("org.eclipse.jdt:org.eclipse.jdt.annotation:".concat(version));
     }
 
     public void addEclipse() {
-      this.addEclipse("+");
+      this.addEclipse("2.2.700");
     }
   }
 }
diff --git a/src/test/java/io/github/joselion/strictnullcheck/lib/StrictNullCheckExtensionTest.java b/src/test/java/io/github/joselion/strictnullcheck/lib/StrictNullCheckExtensionTest.java
@@ -93,7 +93,7 @@
 
         final var dependencies = extension.getSource().getDependencies().get();
 
-        assertThat(dependencies).contains("com.google.code.findbugs:jsr305:+");
+        assertThat(dependencies).contains("com.google.code.findbugs:jsr305:3.0.2");
       }
     }
 
@@ -106,7 +106,7 @@
 
         final var dependencies = extension.getSource().getDependencies().get();
 
-        assertThat(dependencies).contains("com.github.spotbugs:spotbugs-annotations:+");
+        assertThat(dependencies).contains("com.github.spotbugs:spotbugs-annotations:4.7.3");
       }
     }
 
@@ -119,7 +119,7 @@
 
         final var dependencies = extension.getSource().getDependencies().get();
 
-        assertThat(dependencies).contains("org.eclipse.jdt:org.eclipse.jdt.annotation:+");
+        assertThat(dependencies).contains("org.eclipse.jdt:org.eclipse.jdt.annotation:2.2.700");
       }
     }
   }

diff --git a/src/testkit/java/io/github/joselion/strictnullcheck/StrictNullCheckPluginTkTest.java b/src/testkit/java/io/github/joselion/strictnullcheck/StrictNullCheckPluginTkTest.java
@@ -91,7 +91,7 @@ task showConfig() {
 
         assertThat(result.getOutput())
           .contains("*** packageInfo.annotations: [my.custom.annotation.NullApi, my.custom.annotation.NullFields]")
-          .contains("*** source.dependencies: [my.custom:annotations:1.5.3, com.google.code.findbugs:jsr305:+]")
+          .contains("*** source.dependencies: [my.custom:annotations:1.5.3, com.google.code.findbugs:jsr305:3.0.2]")
           .contains("BUILD SUCCESSFUL");
       }
     }
@@ -135,7 +135,7 @@ task showConfig() {
 
         assertThat(result.getOutput())
           .contains("*** packageInfo.annotations: [my.custom.annotation.NullApi, my.custom.annotation.NullFields]")
-          .contains("*** source.dependencies: [my.custom:annotations:1.5.3, com.google.code.findbugs:jsr305:+]")
+          .contains("*** source.dependencies: [my.custom:annotations:1.5.3, com.google.code.findbugs:jsr305:3.0.2]")
           .contains("BUILD SUCCESSFUL");
       }
     }