-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: do not run accessibility checks for bots #1319
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 104 104
Lines 5796 5799 +3
Branches 499 500 +1
=======================================
+ Hits 5558 5561 +3
Misses 237 237
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Wait what... You mean you don't get joy from the accessibility bot fighting the dependency bot?! 🤖🪖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve but I'll hold fire for @JoshuaKGoldberg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 thanks!
Agreed on the skipping the whole job, +1.
Honestly this cracks me up every time. I might leave this disabled for one or two personal smaller repos just as a test to see if any bots get into fights again. 😂 |
@all-contributors please add @danvk for infra.
|
We had trouble processing your request. Please try again later. |
Oh the irony |
lol. if it's not that, it's all-contributors/app#468 ... |
🎉 This is included in version v1.57.9 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
See linked issue. I set this up in my repo in danvk/gravlax#58 following typescript-eslint/typescript-eslint#8212. We can wait for a few renovate bot updates on my repo to confirm that this has the desired effect.
I added support for top-level
if
statements on jobs. It's possible to skip an individual step (which is already supported) but skipping the entire job seems more correct: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif