fix: ⚡ royalty price precision

Joystream · Aug 17, 2023 · 2d1167f · 2d1167f
1 parent b312f9c
commit 2d1167f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.gitignore b/.gitignore
@@ -5,6 +5,7 @@
 /**Versions.jsonl
 
 # IDE files
+/.vscode
 /.idea
 src/model/generated
 /schema.graphql

diff --git a/src/mappings/content/utils.ts b/src/mappings/content/utils.ts
@@ -851,7 +851,7 @@ export async function addRoyaltyPaymentNotification(
 }
 
 export function computeRoyalty(royaltyPct: number, price: bigint): bigint {
- const royaltyDecimal = royaltyPct / 100
- const royaltyPrice = Math.floor(royaltyDecimal * Number(price))
- return BigInt(royaltyPrice)
+ const scaledRoyalty = BigInt(Math.round(royaltyPct * 1e7)) // Scale to 10^7 and convert to bigint
+ const royaltyPrice = (scaledRoyalty * price) / BigInt(1e9) // Divide by 10^9 to account for scaling
+ return royaltyPrice
 }
diff --git a/src/server-extension/resolvers/ChannelsResolver/index.ts b/src/server-extension/resolvers/ChannelsResolver/index.ts
@@ -358,7 +358,7 @@ export class ChannelsResolver {
  }
  // otherwise create a new suspension
  const newSuspension = new ChannelSuspension({
- id: uniqueId(8),
+ id: uniqueId(),
  channelId: channel.id,
  timestamp: new Date(),
  })
@@ -414,7 +414,7 @@ export class ChannelsResolver {
  }
  // othewise create new verification
  const newVerification = new ChannelVerification({
- id: uniqueId(8),
+ id: uniqueId(),
  channelId: channel.id,
  timestamp: new Date(),
  })