Orion notifications demo #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* endingAuctionsNfts query * lint * CR fixes: removed archive, modified query, minor fixes * returned completion check --------- Co-authored-by: Artem <Artem Slugin> Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>
* top selling channels initial draft * introduced node-cache for in-memory caching * CR fixes: updated cache key, minor code fix * upgraded performance schema Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com> * restored env variables * removed cache, introduced 0 periodDays option * fixed infinite period query Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com> * removed unused binary files --------- Co-authored-by: Artem <Artem Slugin> Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>
* Introduce new video property and scheduler to update it * Adjust equation and change score to float * Schedule updates in required places * Add mutation to change video weights * Adjust env weights * Fix for newness weight on creation * CR fixes * CR fixes v2 * Update src/mappings/content/video.ts * Update src/mappings/content/video.ts --------- Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>
attemka
approved these changes
Jul 5, 2023
| @@ -0,0 +1 @@ | |||
| ../uuid/dist/bin/uuid | |||
There was a problem hiding this comment.
whole node_modules folder should be excluded in .gitignore
| @Mutation(() => Boolean) | ||
| @UseMiddleware(AccountOnly) | ||
| async markOffChainNotificationAsRead( | ||
| @Args() { notificationId }: NotificationArgs, |
There was a problem hiding this comment.
we should also consider an option for passing multiple IDs for the "read all" function
| import { MailNotifier } from './mail' | ||
|
|
||
| export type NotificationPreferences = { | ||
| commentCreatedInAppNotificationEnabled: boolean |
There was a problem hiding this comment.
codestyle thing: usually when you'll have such large lists, its better to sort the keys in the alphabet order. There's even a prettier\eslint rule of it somewhere, but I think it doesn't worth to include it, lets just sort this one for better readability
1 task
|
closing in favour of #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfinished work.
Contains all the relevant code for the
orion_notificationpoc.in particular I have left some useful queries in
src/authentication-tests/integration-tests/util.shreference #153