Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass event entity arg to notifyTokenHolders function in ProjectToken.RevenueSplitIssued #323

Conversation

zeeshanakram3
Copy link
Contributor

Problem

{"level":5,"time":1711375967343,"ns":"sqd:processor","err":{"stack":"TypeError: em.getRepository(...).findOne is not a function\n    at getNextIdForEntity (/orion/lib/utils/nextEntityId.js:14:60)\n    at addOffChainNotification (/orion/lib/utils/notification/helpers.js:135:76)\n    at addNotification (/orion/lib/utils/notification/helpers.js:209:15)\n    at /orion/lib/mappings/token/utils.js:244:110\n    at /orion/node_modules/p-limit/index.js:23:31\n    at run (/orion/node_modules/p-limit/index.js:23:43)\n    at /orion/node_modules/p-limit/index.js:45:20\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"}}

In the mappings ProjectToken.RevenueSplitIssued mappings we were not passing the event entity to the notifyTokenHolders function, because of that the notification was interpreted as offchain notification and hence using db store/connection as EntityManager instead of EntityManagerOverlay

@zeeshanakram3 zeeshanakram3 merged commit 434bccf into Joystream:master Mar 25, 2024
7 checks passed
malchililj added a commit to malchililj/orion that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants