New CRT marketplace query #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanakram3
requested changes
Jul 14, 2024
There was a problem hiding this comment.
The implementation looks good, would it be possible for you to add unit test for this handler in src/auth-server/tests?
|
|
||
| let listQuerySql = listQuery.sql | ||
|
|
||
| listQuerySql = listQuerySql.replace(/marketplace_token/g, 'marketplace_tokens') |
There was a problem hiding this comment.
This should not be required any longer?
malchililj
pushed a commit
to malchililj/orion
that referenced
this pull request
Sep 3, 2024
* New query * New query for top selling channels * Add materialized view into view migrations * Fix build * Add new migration * Adjust migration and resolver * Small fixes * Make creator token just a view * Fix divison by zero * Correct hot and cold tokens * Make field more generic and increase the period * Major view query rework * Make initial price on amm start correct * Rework resolver extensions * Add new db table * Add new handler for the auth server to record interactions * Add resolver to get most interacted entities for given type * Introduce limiting for custom resolvers * Fix token price change resolver * Fix marketplace token view definition * Introduce user based rate limiting per type and entity * CR fixes * Add tests for user interactions endpoint * Fix build * Fix resolver for most interacted entity * fix: db views generation * debug log * undo: debug log * regenerate auth api docs * change view name from 'marketplace_tokens' to 'marketplace_token' * fix: lint issue --------- Co-authored-by: Zeeshan Akram <97m.zeeshan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.