Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4330 create validator profile #4428

Merged
merged 48 commits into from
Dec 28, 2023
Merged

4330 create validator profile #4428

merged 48 commits into from
Dec 28, 2023

Conversation

eshark9312
Copy link
Contributor

@eshark9312 eshark9312 commented Jun 12, 2023 •
edited by thesan
Loading

Add section to create membership modal for validator's membership.
Add additional step to create membership transaction modal for binding validator's account to the membership.

> Design
> Story

@vercel
Copy link

vercel bot commented Jun 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Dec 28, 2023 4:23pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Dec 28, 2023 4:23pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Dec 28, 2023 4:23pm

@chrlschwb chrlschwb added community-dev issue suitable for community-dev pipeline jsg-code-review labels Jun 14, 2023
thesan
thesan requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase #4428 on the latest dev so you can add a test case for the validator profile creation in the App stories

@eshark9312 eshark9312 requested a review from thesan July 25, 2023 18:56
thesan
thesan requested changes Jul 26, 2023
View reviewed changes
Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eshark9312 please add some tests in packages/ui/src/app/App.stories.tsx.

Just like how there is a "Buy Membership Happy", "Buy Membership Not Enough Fund", and "Buy Membership Tx Failure" there should be one happy case flow and some failure cases.

You can check @IlyaSmiyukha's work in the same file (for the backend registration): https://github.com/Joystream/pioneer/pull/4474/files#diff-7380f0a1250873010f135b13dda41bfe98c692e64e9ec929f2d31598b595e8a5

@thesan thesan mentioned this pull request Dec 22, 2023
Merged
@thesan thesan changed the base branch from dev to validators December 28, 2023 16:17
thesan
thesan approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@thesan thesan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work once again 🙌

I had forgotten to suggest skipping the validator query for until someone claims to be a validator on my last review so I added it in a small commit (especially since I'm not so available rn so going through another review cycle would waste time).

Also I'm merging this on a new validators branch so feature can still be released while the validator dashboard is getting tested.

So from the top of my head what's left is:

@thesan thesan merged commit 23e07ff into Joystream:validators Dec 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesan thesan thesan approved these changes

@chrlschwb chrlschwb chrlschwb approved these changes

@kdembler kdembler Awaiting requested review from kdembler

Assignees
No one assigned
Labels
community-dev issue suitable for community-dev pipeline jsg-code-review scope:validators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eshark9312 @thesan @chrlschwb