Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Funding Request Proposal for Multiple Recipients #2365 #4453
Funding Request Proposal for Multiple Recipients #2365 #4453
Changes from 6 commits
254936f
dead262
4d0bfa0
30651dc
e7517cc
e7d4b82
51ddf50
dc0fb3d
383089d
d06d0ca
1abf1d0
283dd51
91cb882
f4477df
e018470
855aa76
44dcd9a
8fdbc0b
172518f
617ab12
18b3cf5
904d370
59f10f2
9a3d8bb
313eb98
f58a6fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that the changes to this file are now unnecessary. Please run:
git checkout dev -- packages/ui/src/common/components/Modal/Modal.tsx
to reverse these changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing for this file since the validation doesn't happens in the
useYupValidationResolver
anymoreThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a dangerous hack to me. Instead please watch the csv value (currently
accountsAndAmounts
) and reset what should be reset (currentlyhasPreviewedInput
) in auseEffect
.So with the current
accountsAndAmounts
andhasPreviewedInput
it would be something like: