🤯 Refactor add new proposal tests #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thesan
commented
Jul 13, 2023
| await userEvent.click(await modal.findByText('Sign transaction and change mode')) | ||
|
|
||
| expect(await modal.findByText('It failed 🙀')) | ||
| // within(document.body).getByText('Transaction failed') |
There was a problem hiding this comment.
The TransactionStatus popup doesn't appear during the tx.proposalsDiscussion.changeThreadMode
thesan
commented
Jul 13, 2023
| await completeForms(canvasElement, step) | ||
| await userEvent.click(modal.getByText('Sign transaction and Bind Staking Account')) | ||
|
|
||
| expect(await modal.findByText('It failed 🙀')) |
There was a problem hiding this comment.
The transaction failure modal appears behind the add proposal modal in all flows.
As a result even though this element is in the document it's not actually visible.
This was referenced Jul 13, 2023
chrlschwb
approved these changes
Jul 18, 2023
thesan
force-pushed
the
feature/create-proposal-tests
branch
from
3103f9e
to
faaf30d
Compare
thesan
force-pushed
the
feature/create-proposal-tests
branch
from
faaf30d
to
687ffcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of:
proposalstests intoPages > Proposalsstories #3559Link to the stories: https://pioneer-2-storybook-git-feature-create-proposal-tests-joystream.vercel.app/?path=/story/pages-proposals-proposallist-current--default