Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Release 1.5.1 #4481

Merged
merged 26 commits into from
Jul 25, 2023
Merged

🚀 Release 1.5.1 #4481

merged 26 commits into from
Jul 25, 2023

Conversation

thesan
Copy link
Member

@thesan thesan commented Jul 21, 2023

Fixed

  • Do not ask for confirmation to close transaction success modals.
  • Correctly match questions and answers in opening application pages.
  • Do not keep showing the total balance after disconnecting a wallet.
  • Show all applicants on closed opening pages.

Changed

  • Clarify the label copy of the council budget increment proposal input field.
  • Just show past elections cycle id without "round".

thesan and others added 25 commits June 5, 2023 10:08
* Enable ts aliases in scripts

* Make `council:elect` callable from other scripts

* Create proposals with new staking accounts
Because all wellknown accounts are locked once the council is elected.

* Add a `approveProposal` script

* Fix `opening:create` on the liberated chain

* Document `-d BLOCK_TIME`

* Fix `useProposalConstants`
* Refactor `useForumMultiQueryCategoryBreadCrumbs`

* Speedup the `ThreadItemBreadcrumbs` test

* Fix formatter inconsistency on newer node versions

* Fix restore vote test suite on newer node versions
* Upgrade to Storybook 7

* Fix storybook

* Fix the Pioneer build

* Fix Storybook build command

* Deduplicate babel packages some more
* Sort answers before submitting them

* Sort answer more reliably
* Upgrade to TypeScript 5

* Fix type issues

* Upgrade prettier

* Fix linting
* Show all applicants

All applicants means all. Hiding withdrawn (ie. not hired) distorts historic opening view.

* Show all hired, fix stats

* prettier

* Show all hires

---------

Co-authored-by: Joystream Stats <dev@joystreamstats.live>
* Mock Apollo client

* Add some stories for the `ProposalPreview` page

* Fix scroll

* Mock the api

* Mock the api in the ProposalPreview story

* Add utilities to clarify mock data

* Rename the query node mock file

* Mock Accounts, Balances, and Membership providers

* Add members to the stories

* Fix the query node mock

* Simplify chain mocks

* Fix the isCouncilMember case

* Mock discussion whitelist

* Mock all the story environment in one function

* Mock proposalStatusUpdates

* Mock discussionThread posts

* Mock votes

* Move proposalDetailsMap out of the stories file

* Fix storybook styles without affecting the app

* Fix newly failing stories

* Fix proposal component stories

* Move related stories inside "ProposalPreview"
* fix: hide close confirm modal on specific modals

* refactor: remove hideModalWithoutConfirmModal and migrate it into hideModal

* feat: hide modal directly with error or success state

* fix: hide modal criteria

* fix: type issue and hide criteria

* fix: update hideModal action for two modals

* fix hideModal param

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>

* Remove unrelated changes

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: gyroflaw <83718263+gyroflaw@users.noreply.github.com>
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
* Cleanup the CI workflow

* Remove the GH pages workflow
* Rename MoveFoundsModal to MoveFundsModal

* fixup

* tests

---------

Co-authored-by: Oleksandr Korniienko <oleksanderkorn@gmail.com>
Co-authored-by: Joystream Stats <dev@joystreamstats.live>
* Add `@storybook/test-runner`

* Run pages tests only

* Cache dependencies in another job

* Add the storybook-test job

* Fix the cache hit check

* Fix storybook tests
* Add support for interaction tests

* Allow mocking voting round individually

* Move the `ProposalPreview` tests to Storybook

* Fix failing tests
* Do not use Vercel CLI

* Temporarily disable the test CI

* Fix shell syntax

* Attempt to fix the branch name

* Fix shell syntax

* Temporarily only run the Vercel URL generation

* Check the CI state

* Fix CI

* Check `github.event.pull_request.head`

* Fix the url generation for forks

* Test push workflows

* Check whether `jq` is available on GH runners

* Fix CI for non fork PRs

* Use `jq` instead of `node` to extract data

* Remove the `branch-names` action

* Restore the full CI

* Rename the jobs

* Improve formatting

* Use GH substitution over shell variables

* Debug waiting step

* Restore full CI again

* Fail when the Vercel URL is wrong

* Fix the hash generation
Co-authored-by: ilya Smiyukha <ilya.smiyukha@touchcast.com>
* Add modal and transaction support in page stories

* Mock chain numbers as Codec instead of BNs

* Simplify mocking balances

* Improve the `MockApi` type

* Mock transaction results with `TxMock`

* Move the Pages section to the top menu

* Mock the `api.tx.proposalsEngine.vote` transaction

* Always redirects to the current story

* Improve TxMock

* Use a single spy for `onCall` and `onSend`
Because Storybook actions are converted to jest.fn
* Add a story for `VoteForProposalModal`

* Make CKEditor usable in tests

* Rewrite test args rather than merging objects

* Render modals in a container within the canvas

* Add some of VoteforProposalModal tests to the stories

* Fix failing tests

* Simplify mocking balances

* Render the modal container outside of the router

* Add an id to the "Slash Proposal" toggle

* Finalize the VoteForProposalModal Happy cases

* Add failure cases

* Remove the previous VoteforProposalModal tests

* Remove unnecessary `toBeDefined`

* Fix the failing tests
* Update SetCouncilBudgetIncrement

* Update AddNewProposalModal.test.tsx

* AddNewProposalModal.test.tsx
* Include the OnBoardingProvider in all stories

* Mock a wallet

* Mock local storage

* Reorganize storybook nav

* Add SideBar stories

* Remove the spy function in the local storage mock

* Test the on boarding flow

* Test the buy membership modal

* Remove the old BuyMembershipModal tests

* Test localStorage state

* Remove the old OnBoardingModal test

* Simplify some stories from `ProposalPreview`

* Warn about missing QN queries

* Add the OnBoardingOverlay into the sidebar stories

* Reassign the Sidebar stories to App

* Remove the OnboardingOverlay story

* Move the BountiesHeader component out of the App folder

* Replace OnBoardingOverlay tests

* Run the App stories as part of the CI

* Move the App section first

* Fix type error

* Fix stories when mocks is undefined
* Enable linking stories with the Router

* Create current and past proposal stories

* Fix the `RecursivePartial` type

* Improve the type of mock resolvers

* Warn of missing chain data

* Generate current proposals

* Generate past proposals

* Reorganize the proposal stories in the navigation

* Simplify api mocks code
* Reduce fee re-calculation in `AddNewProposalModal`

* Fix the "warningAccepted" logic
* Reduce fee re-calculation in `AddNewProposalModal`

* Fix the "warningAccepted" logic

* Fix the proposal `WarningModal`

* Test the signal proposal flow

* Add "General parameters" tests

* Add "Funding Request" and "Set Referral Cut" tests

* Fix race condition during form validation

* Fix incomplete tests

* Use one story per proposal type

* Add the "Decrease Working Group Lead Stake" test

* Add "Terminate Working Group Lead" test

* Don't initialize number inputs with a 0

* Add Create Working Group Lead Opening test

* Add the Set Working Group Lead Reward test

* Add the Set Max Validator Count test

* Add the Cancel Working Group Lead Opening test

* Add the Set Council Budget Increment test

* Add the Set Councilor Reward test

* Add the Set Membership Lead Invitation Quota test

* Add the Fill Working Group Lead Opening test

* Add the Set Initial Invitation Count test

* Add the Set Initial Invitation Balance test

* Add the Set Membership Price test

* Add the Update Working Group Budget test

* Add the Runtime Upgrade test

* Complete the AddNewProposalHappy test

* Test not enough funds case

* Add transaction failure tests

* Remove the "UI: AddNewProposalModal" test suite

* Fix tests failing in Playwright

* Simplify expected tx parameters amounts

* Fix failing "unit" tests
@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Jul 21, 2023 11:32am
pioneer-2 ✅ Ready (Inspect) Visit Preview Jul 21, 2023 11:32am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Jul 21, 2023 11:32am

Copy link
Contributor

@dmtrjsg dmtrjsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lezzgo 🚀

@thesan thesan merged commit 3b1eeb6 into main Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants