Funding request multiple recipient preview #4509
Conversation
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
| if (proposalDetails?.type === 'fundingRequest') { | ||
| return [ | ||
| { | ||
| renderType: 'Amount', | ||
| label: 'Current WG Budget', | ||
| value: group?.budget, | ||
| }, | ||
| ] as RenderNode[] | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think this works. I'm not sure why but the WG budget that this proposal should show is the content WG.
Here proposalDetails?.group?.id doesn't exist so the budget remain at 0.
Check https://dao-git-fork-vrrayz-funding-request-multiple-r-8b2aed-joystream.vercel.app/#/proposals/preview/374 (if the QN let you)
| result.push({ | ||
| label: '', | ||
| value: undefined, | ||
| renderType: 'Divider', | ||
| }) |
There was a problem hiding this comment.
Also if the page shows one more "statistic" I think this should be removed
| result.push({ | |
| label: '', | |
| value: undefined, | |
| renderType: 'Divider', | |
| }) |
There was a problem hiding this comment.
As discussed on discord, the design changed: #2365 (comment)
| @@ -99,7 +113,7 @@ export const ProposalDetails = ({ proposalDetails }: Props) => { | |||
| } | |||
|
|
|||
| return [] | |||
| }, [membershipPrice, !group]) | |||
| }, [membershipPrice, !group, budget]) | |||
There was a problem hiding this comment.
Nice one !
You even fixed the Update Working Group Budget council budget preview as a bonus !
E.g https://pioneerapp.xyz/#/proposals/preview/519
Continuation of this PR #4453 for issue:
QA: