[backend] add election stage change notifications #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kdembler
changed the title
kdembler
force-pushed
the
backend-election-notifs
branch
from
7c745dc
to
f54b1fc
Compare
thesan
requested changes
Sep 6, 2023
|
Thanks @thesan, fixed |
thesan
added
scope:notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #4511, will rebase once merged.
This PR adds notifications for election stage changes (announcing, voting, revealing). I haven't added support for ELECTION_COUNCIL_ELECTED since it would be happening at the same time as announcing so consolidated both into a single notification.
The issue suggested adding entities fetch to populate email data, but copy suggested in #4274 doesn't include any additional data. I guess we could add details like council term and number of candidates? Will take a look at that tomorrow.
Resolves #4273