Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] improve auth, add change email mutation #4531

Merged
merged 3 commits into from
Sep 8, 2023
Merged

[backend] improve auth, add change email mutation #4531

merged 3 commits into from
Sep 8, 2023

Conversation

kdembler
Copy link
Member

@kdembler kdembler commented Sep 8, 2023

Based on #4522, will rebase after it's merged

Summary of changes:

  • Added initEmailChange mutation
  • Added authenticated member to Context so each mutation doesn't have to extract it manually
  • Added explicit errors when user is not authenticated or token/signature is invalid. This should give clients more info to work with instead of just returning null
  • Added auth tests that check email verification
  • Added auth tests that check email change
  • Minor misc auth and tests improvements

Resolves #4278

@vercel
Copy link

vercel bot commented Sep 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Sep 8, 2023 3:14pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Sep 8, 2023 3:14pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Sep 8, 2023 3:14pm

thesan
thesan reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good again, just 2 comments:

packages/server/src/auth/api/auth.ts Show resolved Hide resolved
packages/server/src/auth/api/member.ts Show resolved Hide resolved
thesan
thesan approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thesan thesan added the backend label Sep 8, 2023
@thesan thesan merged commit 75d290e into Joystream:backend Sep 8, 2023
7 checks passed
@thesan thesan added scope:notifications Notifications subsystem community-dev issue suitable for community-dev pipeline labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesan thesan thesan approved these changes

Assignees
No one assigned
Labels
backend community-dev issue suitable for community-dev pipeline scope:notifications Notifications subsystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdembler @thesan