-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Validator dashboard QA issues #4753
Address Validator dashboard QA issues #4753
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit related to the ExternalResourceLink
constant.
But also please add 2 decimals to the aprs
packages/ui/src/common/components/forms/FilterBox/FilterSearchBox.tsx
Outdated
Show resolved
Hide resolved
There's this intermediate loading state, where we show some weird stats like:
Can we postpone showing this data until we have the full stats? CleanShot.2024-01-30.at.16.08.22.mp4 |
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
packages/ui/src/validators/components/statistics/ValidatorsState.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There's still some talks on Discord about APRs/APYs but I think it's best to merge this now. If some follow ups are needed it should be done in another PR.
Nice work 👍
Validator dashboard QA #4743