Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Sign addOpening tx with role account #4770

Merged
merged 9 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function WorkingGroup() {
const { name } = useParams<{ name: string }>()
const { isLoading, group } = useWorkingGroup({ name: urlParamToWorkingGroupId(name) })
const { workers } = useMyWorkers()
const isLead = useMemo(
const lead = useMemo(
() => group?.isActive && workers.find((w) => w.membership.id === group?.leadId),
[workers, group?.isActive, group?.leadId]
)
Expand Down Expand Up @@ -75,9 +75,9 @@ export function WorkingGroup() {
</StatusGroup>
)}
</PreviousPage>
{group && isLead && currentTab === 'OPENINGS' && (
{group && lead && currentTab === 'OPENINGS' && (
<ButtonsGroup>
<CreateOpeningButton group={group.id} />
<CreateOpeningButton worker={lead} />
</ButtonsGroup>
)}
</PageHeaderRow>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@ import { TransactionButton } from '@/common/components/buttons/TransactionButton
import { PlusIcon } from '@/common/components/icons/PlusIcon'
import { useModal } from '@/common/hooks/useModal'
import { CreateOpeningModalCall } from '@/working-groups/modals/CreateOpening/types'
import { GroupIdName } from '@/working-groups/types'
import { Worker } from '@/working-groups/types'

export interface CreateOpeningButtonProps {
group: GroupIdName
worker: Worker
}

export const CreateOpeningButton = ({ group }: CreateOpeningButtonProps) => {
export const CreateOpeningButton = ({ worker }: CreateOpeningButtonProps) => {
const { showModal } = useModal()
const createOpening = useCallback(
() => showModal<CreateOpeningModalCall>({ modal: 'CreateOpening', data: { group } }),
[group]
() => showModal<CreateOpeningModalCall>({ modal: 'CreateOpening', data: { worker } }),
[worker]
)

return (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import { isLastStepActive } from '@/common/modals/utils'
import { getSteps } from '@/common/model/machines/getSteps'
import { useYupValidationResolver } from '@/common/utils/validation'
import { machineStateConverter } from '@/council/modals/AnnounceCandidacy/helpers'
import { useMyMemberships } from '@/memberships/hooks/useMyMemberships'
import { StyledStepperBody } from '@/proposals/modals/AddNewProposal'
import { useWorker } from '@/working-groups/hooks/useWorker'

import { SuccessModal, CreateOpeningSteps as Steps, ImportOpening } from './components'
import { createOpeningMachine, CreateOpeningMachineState } from './machine'
Expand All @@ -28,11 +28,11 @@ export const CreateOpeningModal = () => {
const [showImport, setShowImport] = useState<boolean>(false)

const { api } = useApi()
const { active: activeMember } = useMyMemberships()
const [state, send, service] = useMachine(createOpeningMachine)
const { hideModal, modalData } = useModal<CreateOpeningModalCall>()

const { group } = modalData
const group = modalData.worker.group.id
const { worker } = useWorker(modalData.worker.id)
const workingGroupConsts = api?.consts[group]

const context = {
Expand All @@ -48,16 +48,17 @@ export const CreateOpeningModal = () => {
}, [machineStateConverter(state.value)])

const { transaction, feeInfo } = useTransactionFee(
activeMember?.controllerAccount,
worker?.roleAccount,
() => {
if (api && group) {
const { ...specifics } = form.getValues() as CreateOpeningForm
const { description, stakePolicy, rewardPerBlock } = getTxParams(group, specifics)
return api.tx[group].addOpening(description, 'Regular', stakePolicy, String(rewardPerBlock))
}
},
[api?.isConnected, activeMember?.id, group, form.formState.isValidating]
[api?.isConnected, worker?.roleAccount, group, form.formState.isValidating]
)

const exportedJsonValue = useMemo(() => {
const { ...specifics } = form.getValues() as CreateOpeningForm
const exportValue = {
Expand Down Expand Up @@ -91,18 +92,18 @@ export const CreateOpeningModal = () => {
if (state.matches('beforeTransaction')) {
return feeInfo?.canAfford ? send('NEXT') : send('FAIL')
}
}, [state, activeMember?.id, feeInfo])
}, [state, feeInfo])

if (!activeMember || state.matches('requirementsFailed')) {
if (state.matches('requirementsFailed')) {
return null
}

if (state.matches('transaction') && transaction && group) {
if (state.matches('transaction') && transaction && worker) {
return (
<SignTransactionModal
buttonText="Sign transaction and Create"
transaction={transaction}
signer={activeMember.controllerAccount}
signer={worker.roleAccount}
service={state.children.transaction}
>
<TextMedium>You intend to create an Opening.</TextMedium>
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/working-groups/modals/CreateOpening/types.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import * as Yup from 'yup'
import { QuestionValueProps } from '@/common/components/EditableInputList/EditableInputList'
import { ModalWithDataCall } from '@/common/providers/modal/types'
import { BNSchema, minContext, minMixed } from '@/common/utils/validation'
import { GroupIdName } from '@/working-groups/types'
import { GroupIdName, Worker } from '@/working-groups/types'

export interface OpeningModalData {
group: GroupIdName
worker: Worker
}

export type CreateOpeningModalCall = ModalWithDataCall<'CreateOpening', OpeningModalData>
Expand Down
Loading