Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪢 Merge Validators into dev #4776

Merged
merged 18 commits into from
Feb 21, 2024
Merged

🪢 Merge Validators into dev #4776

merged 18 commits into from
Feb 21, 2024

Conversation

thesan
Copy link
Member

@thesan thesan commented Feb 15, 2024

eshark9312 and others added 16 commits December 28, 2023 18:19
* Compoenents Created

* RowInline created

* create profile modal complete

* profile modification modal complete

* change BuyMembershipModal to multiTransaction modal

* add Bonding Validator Account Transaction,fix the machine

* fix the bug in machine

* fix the bug

* complete the UI,but did not implement transaction for binding validator account

* lint:fix

* add bondValidatorAcc tx

* update storybook

* fix mistake

* lint fix

* fix storybook

* add storybook for update validator membership

* Revert "fix storybook"

This reverts commit 489d7f6.

* add some happy and failure case

* Metadata to BYTES for UpdateProfile Tx

* buyValidatorMembership flow draft

* update machine, modal flow

* fix machine

* address merge conflicts

* lint --fix

* update MembershipForm, UpdateMembershipForm

* update interaction test

* fix machine self transition condition, correct PlusIcon import

* fix signer, update test

* revert changes on UpdateMembership

* fix

* update app.stories.tsx with validator provider mocking

* Revert "update app.stories.tsx with validator provider mocking"

This reverts commit d3182d2.

* update storybook comment

* update buymembership machine

* update buyMembership machine

* fix

* Fix the duplicated transaction signing

* Improve binding tests

* Change the select validator account function

* add validatorProvider

* check validator account

* Count the membership's root/controller account into the validator membership

* fix

* Skip validator query until it's needed

---------

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
* Revert "remove route, sidebar item, tab, dashboard, modal"

This reverts commit 480cd09.

* Fix the validator hooks

* fix validator page tab

* add responsive

* fix

* lint fix

* fix hook

* add loading, count the current era into uptime

* lint fix

* remove validator dashboard

* address merge conflict

* fix validatorsInfo modal

* fix validatorslist col-layout

* update validator provider

* fix

* lint fix

* fix
* Make validators `APR`, `staking`, and `slashed` optional

* Make `totalRewards` and `rewardPointsHistory` optional too

* Fix the validator details queries

* Filter validator queries

* Fix filters

* Order validators query results

* Skip the membership query when details aren't needed

* Add pagination

* Rename "others" to "nominators"

* Fix the tests

* Filter, sort, and paginate on the last step

* Split the provider code

* Fix pagination on filtered results
* Fix address encoding

* Fix the `query` function of `ProxyApi`

* Same thing for tx: `paymentInfo` and `signAndSend`

* Fix the no latest reward case

* Don't encode the addresses

* Fix tests
* add MyMembership storybook, update updateMembershipFormModal

* fix machine

* update UpdateMembershipModal

* update storybook test

* Run prettier

* fix useValidators hook

* update ValidatorsList storybook test

* remove UpdateMembershipModal unit-test

* fix proposal storybook test

* remove UpdateMembershipModal unit-test

* fix updateMembershipFormModal

* Alice has two validator accounts

* fix
* Rely on observables laziness to filter and sort validators

* Re-implement the status filter

* Re-implement sort by APR

* Show a loader while sorting validators

* Throttle to decrease re-rendering cycles
* Factor common queries

* Fix tests

* Simplify validators mocks

* Factor stakers queries

* Fix APR and the latest reward stat

* Fix uptime stat

* Fix the Era statistic

* Watch `totalIssuance` and `useObservable`

* Move validators mocks to a separate file

* Use the reward average to calculate the APR

* Apply the "do not show again" box decision

* Fix the toggle appearance
* replace spinner with skeleton

* fix
* Pass the signer address to mock tx in interaction tests

* Fix existing tests
* fix validatorlist filter - input notification & enter on empty search box

* don't show validation message until enter key typed

* show 'All' in the filter select as default

* fix validtor card responsiveness

* fix typo 'Norminate'

* rename reward widget label - last era

* fix validator page widgets tooltips

* fix social media icons as hyperlink

* Rename `ExternalResourceLink` and type it

* add 2 decimals to apr

* fix search box not to show invalid choice until type enter

* Update packages/ui/src/memberships/constants/externalResourceLink.ts

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>

* fix

* fix apr calculation

* fix

* add commission tooltip

* Update packages/ui/src/validators/hooks/useValidatorsList.tsx

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>

---------

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
* fix

* Fix failing tests

---------

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
* fix typo, warning layout

* fix validator account select UX

* fix storybook

* fix invalid validator account input

* fix

* fix update validator membership UX

* Factor validator selection

* initialize the updateMembershipForm with the member's current details

* fix create/update membership interaction test

* fix invalid validator account input -  interact test

---------

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Feb 15, 2024 5:56pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Feb 15, 2024 5:56pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Feb 15, 2024 5:56pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants