📱 Improve mobile UI #4781
Merged
📱 Improve mobile UI #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kdembler
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
I haven't actually reviewed the code but given that it's mostly stylistic changes and the app seems to work fine, I think that's fine.
I found some small UI issues on mobile. It's your call what to fix, I think the PR is good to be merged as is:
-
The sign transaction modal looks a bit weird. The fees at the bottom look broken, but the weird vertical spacing of text is not very pleasant as well:
-
The select membership modal also has weird vertical spacing, both "memberships" label and the actual member item should be closer to the top I think?
-
Very small but the email modal buttons spacing looks a bit weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4759