perf(CommonState): ⚡ delay(1500) => delay(0) in NgRx Effects

JuamBer · Nov 27, 2023 · 2b967dc · 2b967dc
1 parent be8c788
commit 2b967dc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -25,7 +25,8 @@
     "Translations",
     "Services",
     "Sidebar",
-    "LanguageSelect"
+    "LanguageSelect",
+    "CommonState"
   ],
   "cSpell.words": [
     "cascadeselect",

diff --git a/src/app/shared/state/common/common.effects.ts b/src/app/shared/state/common/common.effects.ts
@@ -8,7 +8,7 @@ export abstract class CommonEffect<T> {
   loadAll$ = createEffect(() => {
     return this.actions$.pipe(
       ofType(this.actions.loadAll),
-      delay(1500),
+      delay(0),
       map((action: any) => action.payload),
       exhaustMap((requestFilter) => {
         return from(this.service.getAll(requestFilter)).pipe(
@@ -22,7 +22,7 @@ export abstract class CommonEffect<T> {
   loadMore$ = createEffect(() => {
     return this.actions$.pipe(
       ofType(this.actions.loadMore),
-      delay(1500),
+      delay(0),
       map((action: any) => action.payload),
       exhaustMap((requestFilter) => {
         return from(this.service.getAll(requestFilter)).pipe(
@@ -36,7 +36,7 @@ export abstract class CommonEffect<T> {
   loadOne$ = createEffect(() => {
     return this.actions$.pipe(
       ofType(this.actions.loadOne),
-      delay(1500),
+      delay(0),
       mergeMap((action: any) =>
         from(this.service.getOne(action.id)).pipe(
           map((item: any) => this.actions.loadOneSuccess({ payload: item })),
@@ -49,7 +49,7 @@ export abstract class CommonEffect<T> {
   createOne$ = createEffect(() => {
     return this.actions$.pipe(
       ofType(this.actions.create),
-      delay(1500),
+      delay(0),
       mergeMap((action: any) =>
         from(this.service.create(action.payload)).pipe(
           map((created) => this.actions.createSuccess({ payload: created })),
@@ -62,7 +62,7 @@ export abstract class CommonEffect<T> {
   updateOne$ = createEffect(() => {
     return this.actions$.pipe(
       ofType(this.actions.update),
-      delay(1500),
+      delay(0),
       mergeMap((action: any) =>
         from(this.service.update(action.payload)).pipe(
           map((updated) => {
@@ -79,7 +79,7 @@ export abstract class CommonEffect<T> {
   deleteOne$ = createEffect(() => {
     return this.actions$.pipe(
       ofType(this.actions.delete),
-      delay(1500),
+      delay(0),
       mergeMap((action: any) =>
         from(this.service.delete(action.id)).pipe(
           map(() => this.actions.deleteSuccess({ id: action.id })),
@@ -92,7 +92,7 @@ export abstract class CommonEffect<T> {
   count$ = createEffect(() => {
     return this.actions$.pipe(
       ofType(this.actions.count),
-      delay(1500),
+      delay(0),
       mergeMap(() =>
         from(this.service.count()).pipe(
           map((count: any) => this.actions.countSuccess({ payload: count })),