Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for FillArrays to 1, (keep existing compat) #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the FillArrays package from 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12, 0.13 to 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12, 0.13, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@rofinn rofinn force-pushed the compathelper/new_version/2023-03-31-00-22-58-271-03091188577 branch from 5109c6f to 7812850 Compare March 31, 2023 00:23
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #126 (7812850) into master (00fab43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files           5        5           
  Lines         361      361           
=======================================
  Hits          357      357           
  Misses          4        4           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@behinger
Copy link

behinger commented Jun 8, 2023

I am running into version conflicts, is it possible to add fillArrays 1 into the compat entry?

I only checked the first failed test, and it seems to fail only due to a small floating error - but I dont know anything about the internals

Copy link

codecov bot commented Jan 29, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants