Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant to_vec method #69

Merged
merged 4 commits into from
Apr 30, 2021
Merged

Remove redundant to_vec method #69

merged 4 commits into from
Apr 30, 2021

Conversation

mzgubic
Copy link
Collaborator

@mzgubic mzgubic commented Apr 30, 2021

Not needed anymore since JuliaDiff/FiniteDifferences.jl#156

Still tested indirectly via the test_rrules

Copy link
Contributor

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My favourite kind of PR! Please bump the patch, then feel free to merge once you've got the tests passing.

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #69 (aa8b2ca) into master (1cf397b) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   94.90%   94.83%   -0.08%     
==========================================
  Files           6        5       -1     
  Lines         275      271       -4     
==========================================
- Hits          261      257       -4     
  Misses         14       14              
Impacted Files Coverage Δ
src/BlockDiagonals.jl 100.00% <ø> (ø)
src/blockdiagonal.jl 83.33% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf397b...aa8b2ca. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants