Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Nested named tuples #160

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Conversation

cscherrer
Copy link

This PR is to allow nested named tuples, as first described in #126 (comment)

@cscherrer
Copy link
Author

Hi @tkf , I have tests passing locally if I comment out

# if isdefined(StructArrays, :append!!)
#     append!!(xs::StructArrays.StructVector, ys) =
#         StructArrays.append!!(xs, ys)
# else
#     append!!(xs::StructArrays.StructVector, ys) =
#         StructArrays.grow_to_structarray!(xs, ys)
# end

in BangBang/src/structarrays.jl.

There's some type piracy here, and I think BangBang is a lightweight dependency anyway. But I guess things would need to be updated carefully to be sure there's a smooth transition. Any other thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant