Apply suggestions from code review

Co-authored-by: Nick Robinson <npr251@gmail.com>
JuliaCollections · Feb 20, 2024 · 7fb161c · 7fb161c
1 parent 00aa3ed
commit 7fb161c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/circ_deque.jl b/src/circ_deque.jl
@@ -64,7 +64,7 @@ end
 
 @inline Base.@propagate_inbounds function Base.pop!(D::CircularDeque)
  v = last(D)
- Base._unsetindex!(D.buffer, D.last)
+ Base._unsetindex!(D.buffer, D.last) # see issue/884
  D.n -= 1
  tmp = D.last - 1
  D.last = ifelse(tmp < 1, D.capacity, tmp)
@@ -92,7 +92,7 @@ Remove the element at the front.
 """
 @inline Base.@propagate_inbounds function Base.popfirst!(D::CircularDeque)
  v = first(D)
- Base._unsetindex!(D.buffer, D.first)
+ Base._unsetindex!(D.buffer, D.first) # see issue/884
  D.n -= 1
  tmp = D.first + 1
  D.first = ifelse(tmp > D.capacity, 1, tmp)

diff --git a/src/deque.jl b/src/deque.jl
@@ -297,7 +297,7 @@ function Base.pop!(d::Deque{T}) where T
  @assert rear.back >= rear.front
 
  @inbounds x = rear.data[rear.back]
- Base._unsetindex!(rear.data, rear.back)
+ Base._unsetindex!(rear.data, rear.back) # see issue/884
  rear.back -= 1
  if rear.back < rear.front
  if d.nblocks > 1
@@ -323,7 +323,7 @@ function Base.popfirst!(d::Deque{T}) where T
  @assert head.back >= head.front
 
  @inbounds x = head.data[head.front]
- Base._unsetindex!(head.data, head.front)
+ Base._unsetindex!(head.data, head.front) # see issue/884
  head.front += 1
  if head.back < head.front
  if d.nblocks > 1