Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate path for partial_path #644

Merged
merged 2 commits into from
Aug 4, 2020
Merged

deprecate path for partial_path #644

merged 2 commits into from
Aug 4, 2020

Conversation

oxinabox
Copy link
Member

Closes #633
should be merged before #643
which will need to be rebased to delete this deprecation

@oxinabox oxinabox requested a review from kmsquire July 13, 2020 14:45
@eulerkochy
Copy link
Member

Can this be bumped to 0.18-DEV?

@oxinabox
Copy link
Member Author

oxinabox commented Jul 13, 2020 •
edited
Loading

Can this be bumped to 0.18-DEV?

I want to removed it in 0.18,
so the deprecation needs to go into a 0.17.x release

That is why this is marked as:

should be merged before #643

@oxinabox
Copy link
Member Author

oxinabox commented Jul 13, 2020 •
edited
Loading

@yakir12 might want to review.

@oxinabox oxinabox merged commit a60cd18 into master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eulerkochy eulerkochy eulerkochy approved these changes

@kmsquire kmsquire Awaiting requested review from kmsquire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use and export of path
2 participants
@oxinabox @eulerkochy