Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 0.18 #721

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Backports for 0.18 #721

wants to merge 28 commits into from

Conversation

oxinabox
Copy link
Member

This branch hold bug-fixes we are backporting to 0.18.
the 0.19 release will be a long-time coming, since it is out final release pre-1.0
(c.f. #479)

Just creating this PR because I like having a PR for visability.
Do not merge this, ever

@oxinabox oxinabox marked this pull request as draft January 19, 2021 14:00
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@oxinabox
Copy link
Member Author

Includes #720

ChrisRackauckas and others added 16 commits August 9, 2021 10:06
inline a bit to remove an inference trigger
#775)

* Fixed long-standing bug in balanced_tree.jl that corrupted SortedMultiDict
for certain insertions.

* Added test case from issue #773
…t) (#858)

* fix: check key values, not `get` return for haskey(k, orderedrobindict)

* Fix: use isequal in setindex!

* re-fix: use `get` for `in keys()` but descend to the actual id-dict

* Remove accidental paste in docstring

* consolidate tests for issue under testset

---------

Co-authored-by: Micah Rufsvold <mjrufsvold@mathematica-mpr.com>
…racy

[backport] remove tests for `sort(::Dict)`
[Backport] Bugfix for resize in RobinDict
Copy link
Member

@eulerkochy eulerkochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project.toml Outdated Show resolved Hide resolved
nickrobinson251 and others added 5 commits February 20, 2024 18:47
* Use `Base._unsetindex!` in `pop!` and `popfirst!` (#897)

* Bump codecov/codecov-action from 3 to 4

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3...v4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Use `Base._unsetindex!` in `pop!` and `popfirst!` for Deque

So that popped elements are not rooted by the deque and can be
GCed when they drop out of caller scope.

* Test Deque for leaks

* Use `Base._unsetindex!` in `pop!` and `popfirst!` for CircularDeque

So that popped elements are not rooted by the deque and can be GCed
when they drop out of caller scope.

* Test CircularDeque for leaks

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump version

* Make compatible with ancient Julia versions

* fixup! Make compatible with ancient Julia versions

* fixup! fixup! Make compatible with ancient Julia versions

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Kiran Pamnany <kpamnany@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Base.keys() already works on AbstractDict's so we don't need one for
  Accumulator.
- Base.eltype() is already defined for AbstractArray's and CircularBuffer is an
  AbstractVector so it doesn't need to define it again.
- A Base.convert() from AbstractArray to Array is already defined:
  https://github.com/JuliaLang/julia/blob/1ae41a2c0a3ba49d4b39dc4933dddf952b5f7f3c/base/array.jl#L612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.