Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #770

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Conversation

jonas-schulze
Copy link
Contributor

Updating all the outdated doctests has a rather big footprint. I can drop that commit if you prefer.

The global doctest setup in https://github.com/JuliaCollections/DataStructures.jl/blob/master/docs/make.jl#L4 did not work for me. It might be broken due to the common pattern of setting and resetting DocTestSetup in every file.

Follow up to #759
Ref #769

by running `make.jl` with `doctest=:fix` inside `makedocs`.
Julia version was 1.6.2.
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@oxinabox oxinabox merged commit f57330a into JuliaCollections:master Nov 8, 2021
@jonas-schulze jonas-schulze deleted the vector-trie-docs branch November 8, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants