Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: additional fixes from JET, expand the JET check #12

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Conversation

mortenpi
Copy link
Member

Expands the JET CI check by moving from the :typo mode to a custom filtering function. And it will also include a couple of fixes discovered by going through the JET list.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #12 (2b37ec1) into main (886402f) will decrease coverage by 0.05%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   76.68%   76.63%   -0.05%     
==========================================
  Files          16       16              
  Lines        2187     2183       -4     
==========================================
- Hits         1677     1673       -4     
  Misses        510      510              
Impacted Files Coverage Δ
src/jobs/logging-legacy.jl 69.61% <0.00%> (ø)
src/jobs/jobs.jl 89.09% <50.00%> (ø)
src/jobs/logging.jl 53.08% <50.00%> (-2.21%) ⬇️
src/jobs/logging-kafka.jl 70.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mortenpi mortenpi marked this pull request as ready for review July 10, 2023 07:22
@mortenpi mortenpi requested a review from pfitzseb July 10, 2023 07:22
@mortenpi mortenpi merged commit a04b368 into main Jul 12, 2023
11 checks passed
@mortenpi mortenpi deleted the mp/more-jet branch July 12, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants