test: fix is_enabled test when env var is set #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 76.09% 76.09%
=======================================
Files 16 16
Lines 2192 2192
=======================================
Hits 1668 1668
Misses 524 524 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jim-hill-r
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oversight from #22 -- when you set
JULIAHUBJL_LIVE_WINDOWS_TESTS=true, then theis_enabledtests fail since it's designed to change the functions behavior. This patch makes sure we unset the environment variable in the tests.