fix: compare nodespecs based on ngpu/ncpu/mem first, before price #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation says that
nodespec
returns the smallest node, not necessarily the cheapest. This fixes the behavior wherenodespec
(and thereforesubmit_job
) would pick the wrong node if there is a bigger, but cheaper one available, and clarifies the documentation.It also makes the output for
nodespecs()
sorted, but that's an implementation detail, and hence not documented.