Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use match_mode=:any in PackageBundler log tests #50

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Mar 18, 2024

Using match_mode=:any, since it's possible for the Pkg operations to produce other additional log messages, breaking the PackageBundler tests.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.16%. Comparing base (077bcdd) to head (e18ffdc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   79.16%   79.16%           
=======================================
  Files          16       16           
  Lines        2251     2251           
=======================================
  Hits         1782     1782           
  Misses        469      469           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mortenpi mortenpi marked this pull request as ready for review March 18, 2024 06:44
@mortenpi mortenpi requested a review from pfitzseb March 18, 2024 06:44
@mortenpi mortenpi enabled auto-merge (squash) March 18, 2024 06:44
@mortenpi mortenpi changed the title test: use match_mode=:any in PackageBundler log tests test: use match_mode=:any in PackageBundler log tests Apr 2, 2024
@mortenpi mortenpi merged commit ad5d0fb into main Apr 2, 2024
11 checks passed
@mortenpi mortenpi deleted the mp/test-match-any-logs branch April 2, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants