Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PlanarMechanics module #130

Merged
merged 6 commits into from
Sep 10, 2024
Merged

add PlanarMechanics module #130

merged 6 commits into from
Sep 10, 2024

Conversation

baggepinnen
Copy link
Contributor

originally implemented in SciML/ModelingToolkitStandardLibrary.jl#220

@YingboMa some tests fail with JSCompiler but work for MTK, I have indicated those with

 # Yingbo: <comment>

We need this for OXQT, so it's rather high prio to get working. There are two classes of failures

  • setting state priority sometimes lead to ArgumentError: unable to check bounds for indices of type Nothing in sp[indexin(sp_sts, vars)] = nonzeros(sys.info.state_priority)
  • BoundsError: attempt to access 145-element Vector{Vector{Int64}} at index [146] in 𝑑neighbors

@baggepinnen baggepinnen merged commit 83b0e2e into main Sep 10, 2024
2 checks passed
@baggepinnen baggepinnen deleted the planarmechanics branch September 10, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants