Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce some intermediate level parameters #151

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

baggepinnen
Copy link
Contributor

@baggepinnen baggepinnen commented Sep 25, 2024

This PR depends on:

Note to self: If one of the errors

 The initial condition for parameter body₊body₊m isn't provided.
car₊body₊m cannot be converted to Float64. Please provide a default value for the symbolic variables.

appear, it might be due to parameters being forwarded straight through a component like BodyShape using the kwargs..., and the default for the parameter in the inner body does not find the corresponding parameter in the ParentScope (BodyShape). By introducing the same parameter in the BodyShape, this is resolved.

It can also happen if pars aren't provided to the ODESystem constructor in the component that defines them.

@baggepinnen baggepinnen merged commit 714fc3d into main Oct 7, 2024
2 checks passed
@baggepinnen baggepinnen deleted the paramfixes branch October 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant