Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some updates for MTK v9 #53

Merged
merged 18 commits into from
Jun 12, 2024
Merged

some updates for MTK v9 #53

merged 18 commits into from
Jun 12, 2024

Conversation

baggepinnen
Copy link
Contributor

@baggepinnen baggepinnen commented Mar 27, 2024

This PR passes all tests locally with

@chriselrod
Copy link
Contributor

chriselrod commented Mar 27, 2024

Obviously tests are still failing, but mind taking a look at getting this example working?
https://github.com/JuliaComputing/JuliaSimCompiler.jl/issues/201

EDIT: Huh, tests failed to precompile, but this precompiles locally.

@chriselrod
Copy link
Contributor

Mind fixing:

WARNING: Method definition _norm(Any) in module Multibody at /home/chriselrod/.julia/dev/Multibody/src/orientation.jl:3 overwritten at /home/chriselrod/.julia/dev/Multibody/src/forces.jl:142.

src/forces.jl Outdated Show resolved Hide resolved
baggepinnen referenced this pull request in SciML/ModelingToolkitStandardLibrary.jl May 16, 2024
@baggepinnen baggepinnen mentioned this pull request Jun 5, 2024
@baggepinnen baggepinnen merged commit 475291c into main Jun 12, 2024
0 of 2 checks passed
@baggepinnen baggepinnen deleted the MTKv9 branch June 12, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants