Fix incorrect response header content-type reading #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 79.81% 79.81%
=======================================
Files 7 7
Lines 545 545
=======================================
Hits 435 435
Misses 110 110
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tanmaykm
requested changes
Jul 27, 2023
tanmaykm
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #46
This bug is caused by incorrect response header content-type reading.
The response header
respuse "content-type" not "Content-Type" as the key to store MIME. So theheader(resp, "Content-Type", "application/json")always return default value"application/json". That's why all the response content-type will be judged asjsonI don't add any test, cause no file download API in test specs.