Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add delay for docker tools, doc updates #80

Merged
merged 1 commit into from
Jul 26, 2024
Merged

chore: add delay for docker tools, doc updates #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Guidelines For Contributing

### Updating the code generator

The ["openapi-generator"](https://github.com/OpenAPITools/openapi-generator/) repository contains the code generator for Julia. For any changes that also need updates to the generated code, a PR needs to be made to the `openapi-generator` repo. Relevant files:
- <https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-julia.yaml>
- <https://github.com/OpenAPITools/openapi-generator/tree/master/bin/configs/julia-client-petstore-new.yaml>
- <https://github.com/OpenAPITools/openapi-generator/tree/master/bin/configs/julia-server-petstore-new.yaml>
- <https://github.com/OpenAPITools/openapi-generator/tree/master/samples/client/petstore/julia>
- <https://github.com/OpenAPITools/openapi-generator/tree/master/samples/server/petstore/julia>
- <https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJuliaCodegen.java>
- <https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JuliaServerCodegen.java>
- <https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JuliaClientCodegen.java>
- <https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/julia-client>
- <https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/julia-server>

2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# OpenAPI

[![Build Status](https://github.com/JuliaComputing/OpenAPI.jl/workflows/CI/badge.svg)](https://github.com/JuliaComputing/OpenAPI.jl/actions?query=workflow%3ACI+branch%3Amain)
[![codecov.io](http://codecov.io/github/JuliaComputing/OpenAPI.jl/coverage.svg?branch=main)](http://codecov.io/github/JuliaComputing/OpenAPI.jl?branch=main)
[![codecov](https://codecov.io/gh/JuliaComputing/OpenAPI.jl/branch/main/graph/badge.svg?token=iZeFL7Js0l)](https://codecov.io/gh/JuliaComputing/OpenAPI.jl)

This is the Julia library needed along with code generated by the [OpenAPI generator](https://openapi-generator.tech/) to help define, produce and consume OpenAPI interfaces.

Expand Down
1 change: 1 addition & 0 deletions src/tools.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ function _stop_docker(image_name::AbstractString, image_type::AbstractString; us
return false
end

sleep(5)
container_id = strip(String(read(find_cmd)))
if !isempty(container_id)
rm_cmd = `$docker rm $container_id`
Expand Down
Loading