feat: use native interrupt support in Downloads.jl #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect if we are using a newer version of Download.jl that supports interrupting of requests natively and use that instead of throwing `InterruptException`. ref: JuliaLang/Downloads.jl#256 and JuliaLang/Downloads.jl#259 fixes: #81
krynju
approved these changes
Sep 24, 2024
tanmaykm
added a commit
that referenced
this pull request
Sep 24, 2024
CI with nightlies were disabled earlier because of instabilities. It will be good to enable CI with julia nightlies back again, since #82 needs Downloads.jl version that's included only in the nightlies at the moment.
tanmaykm
added a commit
that referenced
this pull request
Sep 24, 2024
CI with nightlies were disabled earlier because of instabilities. It will be good to enable CI with julia nightlies back again, since #82 needs Downloads.jl version that's included only in the nightlies at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect if we are using a newer version of Download.jl that supports interrupting of requests natively and use that instead of throwing
InterruptException.ref: JuliaLang/Downloads.jl#256 and JuliaLang/Downloads.jl#259
fixes: #81