Skip to content

Commit

Permalink
Merge pull request #82 from baumgold/is_javascript_safe
Browse files Browse the repository at this point in the history
add default is_javascript_safe() function
  • Loading branch information
pfitzseb authored Jun 4, 2021
2 parents 965f404 + 6874a8b commit c1fabb3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "TableView"
uuid = "40c74d1a-b44c-5b06-a7c1-6cbea58ea978"
version = "0.7.0"
version = "0.7.1"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand Down
3 changes: 3 additions & 0 deletions src/TableView.jl
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,9 @@ function _showtable_async!(w, schema, types, rows, tablelength, id, options, opt
onimport(w, handler)
end

# By default all objects must use repr or sprint
_is_javascript_safe(x::Real) = false

function _is_javascript_safe(x::Integer)
min_safe_int = -(Int64(2)^53-1)
max_safe_int = Int64(2)^53-1
Expand Down

2 comments on commit c1fabb3

@pfitzseb
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/38142

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.7.1 -m "<description of version>" c1fabb32c682f3f39fe5c01bd5833968955aef95
git push origin v0.7.1

Please sign in to comment.