Closes #26 - Enable Filtering on async tables #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables default ag-grid style filtering on async tables by creating a filter function from filterModel data.
Minor adjustment to return the invokelatest wrapped filter on the first use. The world will be ready for the actual function on subsequent uses.
Added code to sanitize column access and partially specified ranges. Optimize dates via preparsing.
Handle column names and search text with quote characters more defensively.
|
Thanks for taking a stab at this! |
Updated to generate expressions directly rather than parsing a string.
|
I might have some time to add tests for the filterModel to expression logic in the next couple of days. Feel free to try the latest version and give feedback as it is quite useful. Can't wait to use it in my day job! |
@code_typed shows functions like build_date returning type Union{Missing, Expr} when not using OptionaExpr, but Any after a type assertion when using OptionalExpr. Type inference is better than type assertion if the code is correct I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables default ag-grid style filtering on async tables by creating a filter function from filterModel data.