Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show row number #40

Merged
merged 1 commit into from
Feb 19, 2020
Merged

show row number #40

merged 1 commit into from
Feb 19, 2020

Conversation

pfitzseb
Copy link
Member

image

Not sure if this is what #34 wants -- with this implementation the row number changes when filtering/sorting:
image

@pfitzseb pfitzseb merged commit 96d1f0c into master Feb 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the sp/rownumber branch February 19, 2020 18:49
@nilshg
Copy link

nilshg commented Feb 27, 2020

As the person who opened #34 two observations:

(1) I think ideally the row number would be a fixed column with different style like the column names

(2) From this follows that I also think it should be unchanged, just a very basic indicator of "how far in the current view have I scrolled down"?

(2) is potentially more controversial though, as there are probably valid use cases for both sides of the argument. I suppose my suggestion is more Excel-like, and people would be free to just add a column 1:nrow(df) to their data if they wanted a display with fixed row numbering that is persistent across re-orderings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants