Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a JSON extention #27

Closed
wants to merge 2 commits into from
Closed

Add a JSON extention #27

wants to merge 2 commits into from

Conversation

Azzaare
Copy link

@Azzaare Azzaare commented Sep 5, 2024

Currently, converts an XML file/string to JSON while keeping attributes (including duplicates).

Credits: @oxinabox for the original script for this

EDIT: credits

@Azzaare
Copy link
Author

Azzaare commented Sep 5, 2024

Hmm, Extensions are not supported for the current LTS.

Is it okay to improve Julia requirement to 1.9 ? Otherwise, I need to understand how to handle Require.jl...

EDIT: Opted for ignoring the extensions for versions of Julia before 1.9 (TIL)

@oxinabox
Copy link

oxinabox commented Sep 5, 2024

I don't really understand the need for this in this package.
It might make sense as an example to put in the docs?

@Azzaare
Copy link
Author

Azzaare commented Sep 5, 2024

Oh, I thought it could be useful for other people (some mentioned the need for it in Slack). I just thought it would be convenient to have it somewhere ...

I don't mind either way, as I can put it as a utility function in the package I am making that requires it.

@Azzaare Azzaare marked this pull request as ready for review September 5, 2024 02:59
@joshday
Copy link
Member

joshday commented Sep 11, 2024

Yeah, I like the functionality but I think this is outside the scope of this package.

@joshday joshday closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants