Add rule for indexing by threadid()

threads/index_by_threadid.jl

@@ -0,0 +1,28 @@
+using Base.Threads
+
+states = zeros(10)
+Threads.@spawn for i = 1:10
+ # ruleid: index-by-threadid
+ tid = Threads.threadid()
+ old_val = states[tid]
+ new_val = old_val + i
+ states[tid] = new_val
+end
+
+@spawn begin
+ # ruleid: index-by-threadid
+ tid = threadid()
+ val = states[tid]
+ states[tid] = val + 1
+end
+
+Threads.@spawn for i = 1:10
+ # ruleid: index-by-threadid
+ val = states[threadid()]
+end
+
+
+Threads.@spawn for i = 1:10
+ # ruleid: index-by-threadid
+ val = states[Threads.threadid()]
+end

threads/index_by_threadid.yml

@@ -0,0 +1,21 @@
+rules:
+ - id: index-by-threadid
+ pattern-either:
+ - pattern: |
+ $TID = Threads.threadid()
+ ...
+ $X = $S[$TID]
+ - pattern: |
+ $TID = threadid()
+ ...
+ $X = $S[$TID]
+ - pattern: $S[threadid()]
+ - pattern: $S[Threads.threadid()]
+ message: Indexing by `threadid()` may cause race conditions and should be avoided.
+ metadata:
+ references:
+ - https://julialang.netlify.app/previews/pr1914/blog/2023/06/psa-dont-use-threadid/
+ license: LGPL
+ languages:
+ - julia
+ severity: WARNING